aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorH. Peter Anvin <hpa@zytor.com>2017-04-02 19:28:13 -0700
committerH. Peter Anvin <hpa@zytor.com>2017-04-02 19:36:41 -0700
commit841d904f88884f896735da1292e42615eaaea64f (patch)
tree141bb849caf87cb7387dd8e0f32d47348e7771a9 /tools
parentdd535a6d19d73c31878e461304d326a4c8631843 (diff)
downloadnasm-841d904f88884f896735da1292e42615eaaea64f.tar.gz
nasm-841d904f88884f896735da1292e42615eaaea64f.tar.xz
nasm-841d904f88884f896735da1292e42615eaaea64f.zip
perl: change to the new, safer 3-operand form of open()
The 2-operand form was inherently unsafe. Use the 3-operand form instead, which guarantees that arbitrary filenames are supported. This also means we can remove a few instances of sysopen() which was used for exactly this reason, however, at least in theory sysopen() isn't portable. Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'tools')
-rwxr-xr-xtools/syncfiles.pl4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/syncfiles.pl b/tools/syncfiles.pl
index 4da87f9c..b93e3ed2 100755
--- a/tools/syncfiles.pl
+++ b/tools/syncfiles.pl
@@ -67,7 +67,7 @@ $first_file = $ARGV[0];
die unless (defined($first_file));
foreach $file (@ARGV) {
- open(FILE, "< $file\0") or die;
+ open(FILE, '<', $file) or die;
# First, read the syntax hints
%hints = %def_hints;
@@ -116,7 +116,7 @@ foreach $file (@ARGV) {
# Write the file back out
if (!$first) {
- open(FILE, "> $file\0") or die;
+ open(FILE, '>', $file) or die;
print FILE @lines;
close(FILE);
}