aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>2018-10-04 16:40:36 -0500
committerLeonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>2018-10-08 09:11:30 -0500
commitc892ae04f47908479220247a311bc0067229b592 (patch)
treee54a96320445e9630e1ed0ea8c23cefd217bb584
parenta68ec8eac27ba5bed195bf574fdc0f391cde6fbf (diff)
downloadtermbaud-c892ae04f47908479220247a311bc0067229b592.tar.gz
termbaud-c892ae04f47908479220247a311bc0067229b592.tar.xz
termbaud-c892ae04f47908479220247a311bc0067229b592.zip
benchtests: Set float type on --threshold argument
Otherwise, we see the following runtime error when using the parameter: File "./glibc/benchtests/scripts/compare_bench.py", line 46, in do_compare if d > threshold: TypeError: '>' not supported between instances of 'float' and 'str' * benchtests/scripts/compare_bench.py (main): set float type on threshold argument.
-rw-r--r--ChangeLog5
-rwxr-xr-xbenchtests/scripts/compare_bench.py2
2 files changed, 6 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 70782a6dd5b..af0f15b468e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-10-08 Leonardo Sandoval <leonardo.sandoval.gonzalez@intel.com>
+
+ * benchtests/scripts/compare_bench.py (main): set float type on
+ threshold argument.
+
2018-10-08 Rafal Luzynski <digitalfreak@lingonborough.com>
[BZ #23740]
diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py
index 88e8911d812..f4b7742f903 100755
--- a/benchtests/scripts/compare_bench.py
+++ b/benchtests/scripts/compare_bench.py
@@ -175,7 +175,7 @@ if __name__ == '__main__':
parser.add_argument('--schema',
default=os.path.join(os.path.dirname(os.path.realpath(__file__)),'benchout.schema.json'),
help='JSON file to validate source/dest files (default: %(default)s)')
- parser.add_argument('--threshold', default=10.0, help='Only print those with equal or higher threshold (default: %(default)s)')
+ parser.add_argument('--threshold', default=10.0, type=float, help='Only print those with equal or higher threshold (default: %(default)s)')
args = parser.parse_args()