aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>2013-01-23 08:25:54 +0000
committerMike Blumenkrantz <michael.blumenkrantz@gmail.com>2013-01-23 08:25:54 +0000
commit18bd14af98e077c8ded156a2e0276c62615b1821 (patch)
tree26bb0666e37307d6b1171164ed12f72d777511ec
parentef2d1399673fc4bea4cc9e023c3e5000e80c04c7 (diff)
downloadenlightenment-18bd14af98e077c8ded156a2e0276c62615b1821.tar.gz
enlightenment-18bd14af98e077c8ded156a2e0276c62615b1821.tar.xz
enlightenment-18bd14af98e077c8ded156a2e0276c62615b1821.zip
module error dialog is no longer remembered across restarts: this caused a crash for me on two different machines, so there's another strange and related bug here somewhere...
SVN revision: 83126
-rw-r--r--ChangeLog4
-rw-r--r--NEWS1
-rw-r--r--src/bin/e_module.c6
3 files changed, 8 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 7e288bc4b..4486fd3e9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-01-23 Mike Blumenkrantz
+
+ * module error dialog is no longer remembered across restarts
+
2013-01-22 Mike Blumenkrantz
* No longer build illume edj files
diff --git a/NEWS b/NEWS
index f652b9c78..536f73cc3 100644
--- a/NEWS
+++ b/NEWS
@@ -110,3 +110,4 @@ Fixes:
* Reuse notifications for mixer and battery modules.
* fixed gadget dragging on desktop near screen edges
* fixed bug where "don't composite fullscreen windows" option would cause some windows to stop appearing
+ * module error dialog is no longer remembered across restarts
diff --git a/src/bin/e_module.c b/src/bin/e_module.c
index b4b6abe3f..77d5d8691 100644
--- a/src/bin/e_module.c
+++ b/src/bin/e_module.c
@@ -696,9 +696,8 @@ _e_module_dialog_disable_show(const char *title, const char *body, E_Module *m)
char buf[4096];
printf("MODULE ERR:\n%s\n", body);
- dia = e_dialog_new(e_container_current_get(e_manager_current_get()),
- "E", "_module_unload_dialog");
- if (!dia) return;
+ dia = e_dialog_new(NULL, "E", "_module_unload_dialog");
+ EINA_SAFETY_ON_NULL_RETURN(dia);
snprintf(buf, sizeof(buf), "%s<br>%s", body,
_("What action should be taken with this module?<br>"));
@@ -709,6 +708,7 @@ _e_module_dialog_disable_show(const char *title, const char *body, E_Module *m)
e_dialog_button_add(dia, _("Unload"), NULL, _e_module_cb_dialog_disable, m);
e_dialog_button_add(dia, _("Keep"), NULL, NULL, NULL);
e_win_centered_set(dia->win, 1);
+ dia->win->state.no_remember = 1;
e_dialog_show(dia);
}