From 1d81d5e3944dd5ac912150bc705fa7259eade541 Mon Sep 17 00:00:00 2001
From: Luciano Rocha <strange@nsk.no-ip.org>
Date: Wed, 23 May 2007 21:50:16 +0100
Subject: Don't clobber /dev/null when compiling as root

Compiling as root is highly discouraged, but some people do it anyway.
gcc_ok, however, can clobber /dev/null due to "-o /dev/null"; this is
bad.  Instead, write a temporary file and delete it.
---
 mtools/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'mtools/Makefile')

diff --git a/mtools/Makefile b/mtools/Makefile
index 546e3d14..16d63a69 100644
--- a/mtools/Makefile
+++ b/mtools/Makefile
@@ -1,5 +1,7 @@
-gcc_ok   = $(shell if gcc $(1) ../dummy.c -o /dev/null 2>/dev/null; \
-	           then echo '$(1)'; else echo '$(2)'; fi)
+TMPFILE = $(shell mktemp /tmp/gcc_ok.XXXXXX)
+
+gcc_ok   = $(shell tmpf=$(TMPFILE); if gcc $(1) ../dummy.c -o $$tmpf 2>/dev/null; \
+	           then echo '$(1)'; else echo '$(2)'; fi; rm -f $$tmpf)
 
 comma   := ,
 LDHASH  := $(call gcc_ok,-Wl$(comma)--hash-style=both,)
-- 
cgit